tymurbaniak/ConceptSketch
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Compare commits

base: tymurbaniak:bba49e019e736bc3e5dc8545961b2e5450bd0f9d
Branches Tags
tymurbaniak:main tymurbaniak:claude/issue-10
...
compare: tymurbaniak:47339165232ee94573c4083a461b9812b5507f9c
Branches Tags
tymurbaniak:claude/issue-10 tymurbaniak:main

2 Commits
bba49e019e ... 4733916523

Author SHA1 Message Date
tymurbaniak
4733916523 Merge pull request 'Fix: Breadcrumb disappearing' (#3) from claude/issue-2 into master 
Reviewed-on: #3
 2026-03-23 14:41:42 +00:00
Claude Bot
eb3a23ab03 fix: resolve stale closure causing breadcrumbs to disappear on back-navigation (closes #2) 
The onClick handler in createPathSegment closed over the graphsPath variable
from the render when the segment was created. By the time a breadcrumb was
clicked (after further navigation), that closure was stale, so findIndex
returned -1 and splice(0) wiped the entire breadcrumb array.

Fix: use the functional updater form of setGraphsPath so findIndex runs
against the current state rather than a stale snapshot.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-03-22 22:57:48 +00:00
1 changed files with 1 additions and 6 deletions
Expand all files Collapse all files

7
src/components/Graph.tsx
View File

@@ -264,12 +264,7 @@ const Graph = forwardRef<GraphHandle, { setGraphPath: React.Dispatch<React.SetSt
title: selectedNodeName,
key: pathSegmentId,
onClick: () => {
const index = graphsPath.findIndex(p => p.key === pathSegmentId);
setGraphsPath(prev => {
prev.splice(index + 1);
return [...prev];
});
setGraphsPath(prev => prev.slice(0, prev.findIndex(p => p.key === pathSegmentId) + 1));
selectGraphId(pathSegmentId);
}
} as BreadcrumbItemType;